test: Use XCTestExpectation for delay non blocking #5901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we would remove the method delayNonBlocking, but that requires a few changes to a handful of tests. Instead, we remove the dispatch group wait call which could hang tests forever in CI. Now tests using delayNonBlocking will fail with an assert instead.
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5901 +/- ##
=============================================
- Coverage 86.686% 86.675% -0.011%
=============================================
Files 423 423
Lines 36527 36527
Branches 17281 17277 -4
=============================================
- Hits 31664 31660 -4
- Misses 4815 4821 +6
+ Partials 48 46 -2 see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philipphofmann
deleted the
test/use-xctestexcpectation-delay-non-blocking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we would remove the method delayNonBlocking, but that requires a few changes to a handful of tests. Instead, we remove the dispatch group wait call, which could hang tests forever in CI. Now tests using delayNonBlocking will fail with an assert instead.
I had to define the method as an extension to XCTestCase to use
XCTestCase.wait.Contributes to #5789
#skip-changelog